Isn't version a str?

[DimitriPapadopoulos]

In the following code, the type hint for version is str. Yet, the code has been modified to handle floats too (#189).

Should the type hint be changed from str to str | float?

ome-zarr-py/ome_zarr/format.py

Lines 12 to 16 in 6a1de2a

	def format_from_version(version: str) -> "Format":
	for fmt in format_implementations():
	# Support floating-point versions like `0.2`
	if isinstance(version, float):
	version = str(version)

[DimitriPapadopoulos]

And here, the type hint for well is str. Why use str(well)? Defensive programming?

ome-zarr-py/ome_zarr/format.py

Lines 137 to 140 in 6a1de2a

	def generate_well_dict(
	self, well: str, rows: List[str], columns: List[str]
	) -> dict:
	return {"path": str(well)}

[DimitriPapadopoulos]

Isn't parent_dir a str? It could be perhaps None (if input_path is empty or doesn't contain a slash) , but do you really want to use "None" in that corner case?

ome-zarr-py/ome_zarr/utils.py

Lines 58 to 59 in 6a1de2a

	parent_dir, image_name = os.path.split(input_path)
	parent_dir = str(parent_dir)