Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test vizarr #1

Open
will-moore opened this issue Apr 19, 2021 · 3 comments
Open

Test vizarr #1

will-moore opened this issue Apr 19, 2021 · 3 comments

Comments

@will-moore
Copy link
Member

@joshmoore I assume we could test vizarr using a Docker container specified in this repo instead of in the vizarr repo, in order not to pollute that repo with OME's code?

@joshmoore
Copy link
Member

Exactly. If there's a Dockerfile somewhere that does what you want, then you can follow https://github.com/ome/ome_zarr_test_suite/blob/main/scripts/omero_ms_zarr_fake . Otherwise, create a subdirectory there that contains a Dockerfile and we'll go from there. 👍

@will-moore
Copy link
Member Author

I was thinking of:

  1. Using Docker with http-server to serve the test data (with cors).

  2. Then checkout and build a particular branch of vizarr, or possibly use the PR builds e.g. PR 85 deploy-preview-85 to consume and display the data.

  3. Finally, use pageres-cli to grab a browser screenshot of the app. Either this could be compared with a known valid screenshot, or some other simpler validation that at least the image is displayed.

I managed 1) OK, but failed with 3) - getting errors with puppeteer which referred me to https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md#running-puppeteer-in-docker but I didn't manage to get any of the solutions there working

@joshmoore
Copy link
Member

Don't know if it will be of any use but seealso: zarr-developers/zarr_implementations#21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants