Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "masks/" to "labels/" #59

Open
joshmoore opened this issue Jul 23, 2020 · 2 comments
Open

Rename "masks/" to "labels/" #59

joshmoore opened this issue Jul 23, 2020 · 2 comments
Assignees

Comments

@joshmoore
Copy link
Member

@sbesson points out that since we decided to move to the "labeled-image" naming/structure, the use of "masks/" as a group name is now potentially confusing. "labels/" is likely as good and will give us a chance to test a breaking change from v0.1 to v0.2!

@joshmoore
Copy link
Member Author

PRs opened to unify on "labels". Note this is a breaking change but such data was not fully released so I'm unsure whether or not to treat it as such. With a little work, most of the code bases could be taught to handle both versions so that both 0.0.12 and the next version of ome-zarr-py could be handled.

It may be easier to simply update the datasets to have both for the moment, and then delete masks/ at some point in the future. These datasets need updating:

6001237.zarr/
6001238.zarr/
6001239.zarr/
6001240.zarr/
6001241.zarr/
6001242.zarr/
6001243.zarr/
6001244.zarr/
6001245.zarr/
6001246.zarr/
6001247.zarr/
6001248.zarr/
6001249.zarr/
6001250.zarr/
6001251.zarr/
6001252.zarr/
6001254.zarr/
6001255.zarr/
6001256.zarr/
6001258.zarr/
9836950.zarr/

cc: @dominikl @will-moore @mtbc

@joshmoore joshmoore self-assigned this Sep 7, 2020
@joshmoore
Copy link
Member Author

Once the color decision is made, this change should be applied to all public datasets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant