Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python-dateutil #92

Open
CTV-2023 opened this issue Sep 7, 2023 · 7 comments
Open

Update python-dateutil #92

CTV-2023 opened this issue Sep 7, 2023 · 7 comments

Comments

@CTV-2023
Copy link

CTV-2023 commented Sep 7, 2023

Hi,

I onelogin 3.1.6 to connect to Netbox tool using saml (python-saml==1.15.0)

Onelogin requires python-dateutil~=2.7.0 but we use python-dateutil 2.8.2, which is required by ghp-import 2.1.0 (requires python-dateutil >=2.8.1), used in Netbox.

Is there a way to make onelogin to accept a newer version of dateutil ?

@slewis89898
Copy link

Same issue, did you find a workaround?

@CTV-2023
Copy link
Author

No unfortunately. I ignore the warning when I update Netbox as I don't use ghp-import

@slewis89898
Copy link

Thanks for the quick reply. I'll try that.

@slewis89898
Copy link

No unfortunately. I ignore the warning when I update Netbox as I don't use ghp-import

Hey so I figured out what was wrong - what netbox is actually looking for is not this onelogin python sdk.
What it wants is python3-saml, adding that to your local_requirements.txt will fix everything (may have a slight issue when installing that package but I was able to fix that by installing one thing on the server.

@CTV-2023
Copy link
Author

No unfortunately. I ignore the warning when I update Netbox as I don't use ghp-import

Hey so I figured out what was wrong - what netbox is actually looking for is not this onelogin python sdk. What it wants is python3-saml, adding that to your local_requirements.txt will fix everything (may have a slight issue when installing that package but I was able to fix that by installing one thing on the server.

I have both in my requirements. If I remember correctly python3-saml needed it

@VaibhavVadate
Copy link

we are also using onelogin with fastapi pydantic v2, getting same compatible issue
\venv\lib\site-packages\onelogin\models\create_app200_response.py", line 42, in CreateApp200Response
one_of_schemas: List[str] = Field(CREATEAPP200RESPONSE_ONE_OF_SCHEMAS, const=True)
\venv\lib\site-packages\pydantic\fields.py", line 763, in Field
raise PydanticUserError('const is removed, use Literal instead', code='removed-kwargs')
pydantic.errors.PydanticUserError: const is removed, use Literal instead

For further information visit https://errors.pydantic.dev/2.4/u/removed-kwargs

can we please help me on this.
@onelogin-security-bot

@mg-christian-axelsson
Copy link

Bumping this. python-dateutil fixes deprecation warnings introduced in Python 3.12 and will hence be required in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants