Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really-executable plugin doesn't honor programFile argument. #1

Open
sureshg opened this issue Jun 7, 2017 · 2 comments
Open

Really-executable plugin doesn't honor programFile argument. #1

sureshg opened this issue Jun 7, 2017 · 2 comments

Comments

@sureshg
Copy link
Member

sureshg commented Jun 7, 2017

The OneOps plugin version mainly depends on the shadow jar name and classifier to create the final binary name and doesn't honor programFile flag.
https://github.com/oneops/really-executable-jar-maven-plugin/blob/master/src/main/java/org/skife/waffles/ReallyExecutableJarMojo.java#L66-L70

Looks like in the original plugin has proper support for this one - https://github.com/brianm/really-executable-jars-maven-plugin/blob/master/src/main/java/org/skife/waffles/ReallyExecutableJarMojo.java#L123-L130

@jvanzyl
Copy link
Contributor

jvanzyl commented Jun 7, 2017

This was purely done for Boo and changes to allow both and uber JAR and an executable uber JAR. Nexus considers the executable JAR tampered with and can't be proxied correctly. So to keep most Boo users happy I changed the plugin so that I could produce both. Both forms are used heavily now.

@mosabua
Copy link

mosabua commented Jun 7, 2017

Can we push this to the upstream plugin instead of maintaining a fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants