comment get attached to wrong node when it precedes the move

[toomasr]

I noticed that sometimes the comments felt out of place. I tracked this down to comments preceding the move property. I couldn't figure out a fix though. I hope the test case helps.

test("test for comments being attached to right nodes", () => {
    let sgfStr = "(;GM[1]FF[4]CA[UTF-8]AP[CGoban:3]ST[2] RU[Japanese]SZ[19]KM[0.00]PW[White]PB[Black];W[aa]C[Comment after move property];W[pd])";
    let goban = new TestGoban({ original_sgf: sgfStr, removed: "",  });

    goban.engine.jumpToOfficialMoveNumber(0);
    
    expect(goban.engine.cur_move.text).toMatch("");
    goban.engine.showNext();
    expect(goban.engine.cur_move.text).toMatch("Comment after move property");
    
    // now let's have the comment before the move property
    sgfStr = "(;GM[1]FF[4]CA[UTF-8]AP[CGoban:3]ST[2] RU[Japanese]SZ[19]KM[0.00]PW[White]PB[Black];C[Comment before move property]W[aa];W[pd]C[second comment])";

    goban = new TestGoban({ original_sgf: sgfStr, removed: "",  });
    goban.engine.jumpToOfficialMoveNumber(0);

    expect(goban.engine.cur_move.text).toMatch("");
    goban.engine.showNext();
    expect(goban.engine.cur_move.text).toMatch("Comment before move property");
    goban.engine.showNext();
    expect(goban.engine.cur_move.text).toMatch("Second comment");
});

[anoek]

Interesting, do you have an example game too by any chance?

[toomasr]

I have many such files. Most of the problems I get from my teacher have this. I see the tool used is GoWrite.

[anoek]

If you can provide a link to an example game that would be very helpful, that way we have something we can start debugging from and validate works when a fix is released.

[toomasr]

Here you go https://toomasr.com/problematic.sgf