This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Co-located task scheduler does not respect capacity contrains #880
Comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hello,
The
:onyx.task-scheduler/colocatedscheduler does not respect tasks':onyx/max-peersconstrain. I do not know if there is a reason for that. The code seems to explicitly prevent it: https://github.com/onyx-platform/onyx/blob/0.14.x/src/onyx/scheduling/colocated_task_scheduler.clj#L114-L116Is it a feature ? If so could we make it an option (I'd be happy to provide a PR) ? I need a version of this scheduler that respects tasks capacity constrains. Is there something wrong in just returning
truehere instead ? I did a few tests with this modification, simulating multiple peers with docker, and there was no errors.Any thoughts ?
The text was updated successfully, but these errors were encountered: