Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probe-desktop: error after start #1318

Closed
xhdix opened this issue Jul 8, 2020 · 6 comments
Closed

probe-desktop: error after start #1318

xhdix opened this issue Jul 8, 2020 · 6 comments
Assignees
Labels
bug Something isn't working correctly ooni/probe-desktop platform/macos platform/windows priority/high Important issue that needs attention soon

Comments

@xhdix
Copy link

xhdix commented Jul 8, 2020

It seems due to the failure to check for updates!
Probe-Desktop v3.0.1
Windows 10
TCI ;)

Unhandled Promise Rejection
Error: net::ERR_CONNECTION_CLOSED
    at SimpleURLLoaderWrapper.<anonymous> (electron/js2c/browser_init.js:2519:21)

(electron) 'getName function' is deprecated and will be removed. Please use 'name property' instead.
12:29:01.792 > App starting...
12:29:01.880 > Checking for update
12:29:01.914 > Checking for update
(node:13960) DeprecationWarning: Passing functions, DOM objects and other non-cloneable JavaScript objects to IPC methods is deprecated and will throw an exception beginning with Electron 9.
(node:13960) DeprecationWarning: Passing functions, DOM objects and other non-cloneable JavaScript objects to IPC methods is deprecated and will throw an exception beginning with Electron 9.
12:29:32.604 > Error: Error: net::ERR_CONNECTION_CLOSED
    at SimpleURLLoaderWrapper.<anonymous> (electron/js2c/browser_init.js:2519:21)
    at SimpleURLLoaderWrapper.emit (events.js:210:5)
    at SimpleURLLoaderWrapper.EventEmitter.emit (domain.js:476:20)
    at SimpleURLLoaderWrapper.topLevelDomainCallback (domain.js:131:23)
12:29:32.659 > Error in auto-updater. Error: net::ERR_CONNECTION_CLOSED
This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: net::ERR_CONNECTION_CLOSED
    at SimpleURLLoaderWrapper.<anonymous> (electron/js2c/browser_init.js:2519:21)
    at SimpleURLLoaderWrapper.emit (events.js:210:5)
    at SimpleURLLoaderWrapper.EventEmitter.emit (domain.js:476:20)
    at SimpleURLLoaderWrapper.topLevelDomainCallback (domain.js:131:23)
Error: net::ERR_CONNECTION_CLOSED
    at SimpleURLLoaderWrapper.<anonymous> (electron/js2c/browser_init.js:2519:21)
    at SimpleURLLoaderWrapper.emit (events.js:210:5)
    at SimpleURLLoaderWrapper.EventEmitter.emit (domain.js:476:20)
    at SimpleURLLoaderWrapper.topLevelDomainCallback (domain.js:131:23)
(node:2616) DeprecationWarning: Passing functions, DOM objects and other non-cloneable JavaScript objects to IPC methods is deprecated and will throw an exception beginning with Electron 9.
(node:2616) DeprecationWarning: Passing functions, DOM objects and other non-cloneable JavaScript objects to IPC methods is deprecated and will throw an exception beginning with Electron 9.

image

image

@hellais hellais transferred this issue from ooni/probe-desktop Dec 4, 2020
@bassosimone bassosimone changed the title Error after start probe-desktop: error after start Dec 4, 2020
@bassosimone bassosimone assigned sarathms and unassigned bassosimone Jan 7, 2021
@bassosimone
Copy link
Contributor

It seems @sarathms is more qualified than me to triage this issue.

@sarathms sarathms transferred this issue from ooni/probe-engine Jan 7, 2021
@sarathms sarathms added bug Something isn't working correctly effort/M ooni/probe-desktop priority/high Important issue that needs attention soon labels Jan 7, 2021
@sarathms sarathms added this to the Sprint 31 - Rhincodon milestone Jan 7, 2021
@sarathms
Copy link

sarathms commented Jan 7, 2021

This should be addressed by adding a autoUpdater.on('error', handleFn) in main/index.js. Thanks for reporting this @xhdix. I will make sure this is fixed in the next release.

@xhdix
Copy link
Author

xhdix commented Jan 7, 2021

You're welcome @sarathms !
Now, months after this report, it seems that at TCI (AS58224) they are detecting and blocking ElectronJS JA3. (This doesn't happen in MCI (AS197207).)

@sarathms
Copy link

As a longer term solution to this issue, we will be changing the auto-update provider to use something that is more resilient. This work is tracked in #1496

@sarathms
Copy link

sarathms commented Jun 4, 2021

For the short term, we now check for updates differently and are able to catch these errors and notify the unavailability of updates and request visiting our website to fetch the latest version.

@sarathms
Copy link

sarathms commented Jun 4, 2021

Closing this issue for now. Thanks @xhdix for your time and patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly ooni/probe-desktop platform/macos platform/windows priority/high Important issue that needs attention soon
Projects
None yet
Development

No branches or pull requests

3 participants