Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

th: emit real error we observed #2422

Open
bassosimone opened this issue Feb 22, 2023 · 0 comments
Open

th: emit real error we observed #2422

bassosimone opened this issue Feb 22, 2023 · 0 comments
Assignees
@bassosimone
Labels
bug Something isn't working correctly data quality enhancement New feature request or improvement to existing functionality methodology issues related to the testing methodology ooni/probe-engine priority/low Nice to have user feedback requests that have been added to the backlog as a direct result of user feedback or testing

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Feb 22, 2023 •
edited
Loading

This issue is about extending the JSON returned by the TH to include the real OONI error observed by the control vantage point. By doing that, we will make debugging and understanding control measurements easier. These new fields will be emitted in addition to the currently-emitted failure fields. We cannot change the existing failure fields because they contain strings that are backwards compatible with the legacy Python implementation of the oohelperd.
@bassosimone bassosimone added bug Something isn't working correctly enhancement New feature request or improvement to existing functionality priority/medium Normal priority issue user feedback requests that have been added to the backlog as a direct result of user feedback or testing methodology issues related to the testing methodology data quality ooni/probe-engine labels Feb 22, 2023
@bassosimone bassosimone self-assigned this Feb 22, 2023
@bassosimone bassosimone mentioned this issue Jan 24, 2024
Closed
@hellais hellais added this to Roadmap Jan 7, 2025
@hellais hellais added priority/low Nice to have and removed priority/medium Normal priority issue labels Jan 27, 2025
@hellais hellais moved this to Icebox in Roadmap Jan 27, 2025
@hellais hellais removed this from Roadmap Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
bug Something isn't working correctly data quality enhancement New feature request or improvement to existing functionality methodology issues related to the testing methodology ooni/probe-engine priority/low Nice to have user feedback requests that have been added to the backlog as a direct result of user feedback or testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bassosimone @hellais