Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: synchronize id for ooni and dw descriptor IDs in prod and dev environments. #2824

Closed
aanorbel opened this issue Dec 4, 2024 · 5 comments
Assignees
Labels
bug Something isn't working correctly discuss Needs discussion before proceeding ooni/probe-mobile issues related to OONI Probe mobile platform/android platform/ios priority/medium Normal priority issue triage Should be triaged through the triage board

Comments

@aanorbel
Copy link
Member

aanorbel commented Dec 4, 2024

Describe the bug

  • OONI and NMS Descriptors dont have thesame ID in both development and production

To Reproduce

Steps to reproduce the behavior.

These links should match in both environments.

DW

OONI

Expected behavior

  • The links mentioned above should be thesame in both environments
  • OONI Descriors should have an ID between 00000 and 10000
@aanorbel aanorbel added bug Something isn't working correctly triage Should be triaged through the triage board priority/high Important issue that needs attention soon ooni/probe-mobile issues related to OONI Probe mobile platform/android platform/ios labels Dec 4, 2024
@aanorbel
Copy link
Member Author

aanorbel commented Dec 6, 2024

Hi @DecFox , is there a particular reason why the OONI Descriptors cant start with a whole number? 00100 - 00104 would have been preferable

@hellais hellais added this to Roadmap Jan 7, 2025
@hellais
Copy link
Member

hellais commented Jan 23, 2025

is there a particular reason why the OONI Descriptors cant start with a whole number?

Why do we need the OONI Run link ids having a fixed length? OONI Run link IDS should in theory be extensible beyond 99999 and as per spec they should be treated as a string (that means that 00104 is different than 104).

@hellais hellais added the discuss Needs discussion before proceeding label Jan 23, 2025
@hellais hellais moved this to Backlog in Roadmap Jan 23, 2025
@hellais hellais added priority/medium Normal priority issue and removed priority/high Important issue that needs attention soon labels Jan 23, 2025
@aanorbel
Copy link
Member Author

The above examples were following a pattern recognized in the existing OONI Run link IDS.

At the moment, https://api.dev.ooni.io/api/v2/oonirun/links/104, and https://api.dev.ooni.io/api/v2/oonirun/links/00104 are quite different with the former(104) returning a 404. The later returning the actual response.

@hellais hellais removed this from Roadmap Jan 29, 2025
@hellais
Copy link
Member

hellais commented Jan 30, 2025

This is done for DW and we can create a new one for the OONI app in the future

@hellais hellais closed this as completed Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly discuss Needs discussion before proceeding ooni/probe-mobile issues related to OONI Probe mobile platform/android platform/ios priority/medium Normal priority issue triage Should be triaged through the triage board
Projects
None yet
Development

No branches or pull requests

3 participants