Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add English Translation #1033

Open
YoussefHachicha opened this issue Sep 30, 2024 · 8 comments
Open

Add English Translation #1033

YoussefHachicha opened this issue Sep 30, 2024 · 8 comments
Labels
N 一般优先级 t: feature 类型: 新功能

Comments

@YoussefHachicha
Copy link

建议内容

Add English Translation in the app

当前 Ani 版本号

3.0.0

操作系统

No response

@YoussefHachicha YoussefHachicha added N 一般优先级 t: feature 类型: 新功能 labels Sep 30, 2024
@mml-hrb
Copy link

mml-hrb commented Sep 30, 2024

this apps data is based on bangumi -- a Chinese website, and the ani it can play, is mostly chinese sub. i dont think it will be useful for English speaker.

@mml-hrb
Copy link

mml-hrb commented Sep 30, 2024

but I think pr is always welcome

@Him188
Copy link
Member

Him188 commented Sep 30, 2024

I18n is planned, but I can't guarantee when English is going to be added. All of the current devs and users speak simplified or traditional Chinese, so even if we migrate to support multiple languages, we would only add Tranditional Chinese.

Also worth to mention most of the code comments & documentations are also in Chinese. If you are refering to source code, not using the app, an IDE plugin namely Translation might be helpful.

@Him188
Copy link
Member

Him188 commented Sep 30, 2024

If you are looking for CMP libraries - most likely the multiplatform media player - we have a plan of extracting and publishing them
as a standalone library under Apache v2. But this cannot be done unless the player gets stable in the app. There is still a lot of important work there, for example, #464

@NeKoOuO
Copy link
Contributor

NeKoOuO commented Sep 30, 2024

I think if we want to consider English users, perhaps in the future we could support track sites similar to bangumi, like anilist or myanimelist, which would make i18n more reasonable.

Otherwise, the significance of supporting English now is not great. Although you can still use the tourist mode now, there are many features you won't be able to access.

@Him188
Copy link
Member

Him188 commented Sep 30, 2024

Well, Bangumi do support 'English' searching - with Romaji. For example, try "make heroine" or "moshokutensei".

Supporting multiple sources for subject indexing is not technically easy.

@YoussefHachicha
Copy link
Author

I am mainly interested in the source code, the thing is I can't understand what each screen does, since all the content is in Chinese, I had a rough time logging in lol. I will definitely be checking out the IDE plugin you mentioned.

@Him188 Him188 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
@Him188 Him188 reopened this Oct 1, 2024
@Him188
Copy link
Member

Him188 commented Oct 1, 2024

Leaving this open. PR is always wecome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
N 一般优先级 t: feature 类型: 新功能
Projects
None yet
Development

No branches or pull requests

4 participants