Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed-phase moments #1514

Open
tluettm opened this issue Feb 11, 2025 · 4 comments
Open

Mixed-phase moments #1514

tluettm opened this issue Feb 11, 2025 · 4 comments
Assignees

Comments

@tluettm
Copy link
Collaborator

tluettm commented Feb 11, 2025

#1513

The MeanRadius product produces NaN values if ice (negative volume values) are included in the size range and present in the attributes.

Also the WaterMixingRatio product provides a negative mass for integration over ice and is incorrect for summation of ice and liquid water.

I attached a test for these products.

@slayoo slayoo self-assigned this Feb 11, 2025
@slayoo
Copy link
Member

slayoo commented Feb 11, 2025

Thank you, @tluettm

@slayoo
Copy link
Member

slayoo commented Feb 23, 2025

@tluettm, please confirm if #1513 solves this?

@tluettm
Copy link
Collaborator Author

tluettm commented Feb 24, 2025

I found some issues:

If you add 'volume' as an attribute it leads to this error: " ValueError: attribute 'water mass' is a dummy/derived one, but values were provided"

IWC, n_i and r_i are all 0 even if any signed water mass is less than 0. I modified the test. See here:

main...tluettm:PySDM:mixed_moments_new_test

@slayoo
Copy link
Member

slayoo commented Feb 25, 2025

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants