Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--kill-others should work with --success #404

Open
ianpatton opened this issue Feb 17, 2023 · 6 comments
Open

--kill-others should work with --success #404

ianpatton opened this issue Feb 17, 2023 · 6 comments

Comments

@ianpatton
Copy link

  • Description: Using --kill-others to top a process causes it to exit with a non zero exit code. --success specifies that if one process exits cleanly, then concurrently should exit cleanly. It does not.
  • Expected Behavior: concurrently should exit with code 0
  • Environment: MacOS
  • Reproduction: concurrently --kill-others -s last "process-that-doesnt-exit" "tests-that-exit-cleanly"
@40x
Copy link

40x commented Feb 23, 2023

I have a similar issue I believe

I am using the package to run my integration tests. It does two things

  1. start the webpack dev server
  2. run the jest tests against it

Tests run successfully and exit with 0, that in turn triggers the SIGTERM being sent to other processes (as shown in the logs) but the exit code sent to the process on windows is 1 while it is SIGTERM on mac.

We rely on SIGTERM to do some clean-up but because of the way it exits right now, we are unable to do so only on windows.

On Windows -
image

On Mac -
image

@andy265
Copy link

andy265 commented Mar 9, 2023

  • Reproduction: concurrently --kill-others -s last "process-that-doesnt-exit" "tests-that-exit-cleanly"

I could suggest trying to change "last" to "first".

@HoneyQumo
Copy link

@andy265 it's not working.
@dmidnight Is there any update on this issue?

@gustavohenke
Copy link
Member

What @andy265 said is right. --success last refers to the last command to exit, not the last listed command.

@HoneyQumo can you provide any details about what's not working? If I don't have reproduction steps, I can't help.

@gustavohenke
Copy link
Member

@40x it might be better to open a new issue for your use case.
Windows wouldn't have signals, and so tailoring the experience for "exit code 1, but because it was 'interrupted'" is not possible; the process could have sent a different code.

@manoelaog
Copy link

What @andy265 said is right. --success last refers to the last command to exit, not the last listed command.

@HoneyQumo can you provide any details about what's not working? If I don't have reproduction steps, I can't help.

Just a suggestion, complement the documentation with this observation. The description of param are not clear and there are no examples to --success param.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants