-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the field of managedclusteraddon.spec.installNamespace #298
Comments
This issue is stale because it has been open for 120 days with no activity. After 14 days of inactivity, it will be closed. Remove the |
Signed-off-by: Jian Qiu <[email protected]> Signed-off-by: Jian Qiu <[email protected]>
This issue is stale because it has been open for 120 days with no activity. After 14 days of inactivity, it will be closed. Remove the |
This issue is stale because it has been open for 120 days with no activity. After 14 days of inactivity, it will be closed. Remove the |
Now we can use the
managedclusteraddon.spec.installNamespace
field to set which namespace the addon agent will be deployed on the managed clusters. But there are some disadvantages, like usingmanagedclusteraddon.spec.installNamespace
, the value is determined by the addon deployer, not the developer, so for example, if you want to use the addon's installStrategy feature(the ManagedClusterAddon will be created automatically), the value cannot be configured and can only be the default valueopen-cluster-management-agent-addon
So we are exploring a more general way to set up this install namespace; In OCM, when we develop an OCM addon, we only need to implement the AgentAddon interface:
manifests-namespace
;registration-namespace
;The
manifests-namespace
and theregistration-namespace
can be totally decided by the addon developer, for example, in the above two functions you can write code to read the namespace from the API addondeploymentconfig.spec.agentInstallNamespace or make it a fixed value liketest-ns
or any other way. No matter which way, they should be the same value. And the value will be shown in the fieldmanagedclusteraddon.status.namespace
.With this, the
managedclusteraddon.spec.installNamespace
is not required, using the installStrategy feature will not always deploy the agent into theopen-cluster-management-agent-addon
namespace as well.The text was updated successfully, but these errors were encountered: