-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for releases published as part of a record (release_type = 'embedded_release') #110
Comments
I do not see that as a problem. Only we do not want to do it for records with linked releases, so as long as we find a way of detecting them we can another |
Thanks @kindly In OpenDataServices/cove#895 we decided the best was to differentiate between linked and embedded releases was to check for the |
The specific comment is: OpenDataServices/cove#895 (comment) OCDS Kit has a somewhat different test: https://ocdskit.readthedocs.io/en/latest/api/util.html#ocdskit.util.is_linked_release The main addition is that it tests the number of fields. |
* Add digit 3 to the end to disambiguate from other calculated release ids, including others we might add in the future. * Reduce the multiplicative factor to 1000000, because the current maximum number of releases in a record is 363 #110
@duncandewhurst This has been deployed to the server. Could you check this now works as expected? |
Thanks @Bjwebb I created
Also, the documentation will need updating (the |
The data column of the release_summary_with_data table should contain only the release, in the case of embedded releases, not the record it is embedded in. #110
Thanks @duncandewhurst. Those are all useful suggestions, and look easy to change. When I update the data column of |
Without the prefix is better! Thanks |
@duncandewhurst The latest changes are now on the kingfisher server, if you want to review. Just noticed that the docs still need updating, so I'll look into that. |
I've made some update to the docs: PR, view on Read the Docs |
Is #43 related / duplicate? |
@Bjwebb the changes and docs look good, thanks! |
My understanding is that, for record collections, currently kingfisher-views only summarises the
compiledRelease
and doesn't do anything with thereleases
array.This means that for publishers that only publish records, we can't do release-level analysis using kingfisher-views.
How much work would it be to also summarise the individual releases provided as part of a record?
We'd need some way of distinguishing these from the compiled release summaries, which I guess could be done by adding a new
release_type
.For context, this came up when reviewing Paraguay's draft data, which was only shared as records.
The text was updated successfully, but these errors were encountered: