Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beneficial owners: Refer to country codelist #189

Closed
duncandewhurst opened this issue Aug 29, 2022 · 4 comments
Closed

Beneficial owners: Refer to country codelist #189

duncandewhurst opened this issue Aug 29, 2022 · 4 comments
Labels
Codelist Involves editing a codelist Community Relates to a regular extension Schema Involves editing the schema
Milestone

Comments

@duncandewhurst
Copy link

OCDS 1.2 adds a country codelist. The .nationality field in the beneficial owners extension can be updated to refer to this so that it's values can be validated.

@duncandewhurst duncandewhurst added Schema Involves editing the schema Codelist Involves editing a codelist labels Aug 29, 2022
@duncandewhurst duncandewhurst added this to the 1.2.0 milestone Aug 29, 2022
@neelima-j
Copy link

The task is to modify the beneficial owners extension so that nationality validates from the new country codelist instead of the string it is now.

@duncandewhurst The documentation of the extension already mentions that 'nationality' should be "a two-letter, uppercase ISO 3166-1 alpha-2 country code", but should it now be modified to include "from the closed country codelist"?

Is this ready for a PR?

@duncandewhurst
Copy link
Author

That sounds good to me. You can reuse the wording from Address.country in 1.2-dev.

Is this ready for a PR?

I think so, but I'll defer to @jpmckinney to confirm :-)

@jpmckinney
Copy link
Member

Yes, we'll need to create 1.1 and 1.2 branches of the extension, but I can set that up once the PR is ready.

@jpmckinney jpmckinney added the Community Relates to a regular extension label Jan 17, 2023
jpmckinney added a commit to open-contracting-extensions/ocds_beneficialOwners_extension that referenced this issue Jun 8, 2023
@jpmckinney
Copy link
Member

Closed by above commit. A 1.2 branch can be created when OCDS 1.2 is released #202.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Codelist Involves editing a codelist Community Relates to a regular extension Schema Involves editing the schema
Projects
Status: Done
Development

No branches or pull requests

3 participants