Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QASP: Add Security automation #34

Open
jpmckinney opened this issue Sep 30, 2020 · 1 comment
Open

QASP: Add Security automation #34

jpmckinney opened this issue Sep 30, 2020 · 1 comment
Labels
implementation Relating to policy implementation

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Sep 30, 2020

QASP already has the policy; this issue is about automating it.

Consider adding CodeQL workflows, e.g. https://github.com/open-contracting/ocdskit/security/code-scanning See also https://lgtm.com (https://blog.semmle.com/secure-software-github-semmle/)

Can also consider https://bandit.readthedocs.io/en/latest/ from PyCQA. 2024 update: now covered by ruff


From https://guides.18f.gov/derisking/qasp/

Deliverable Performance Standard(s) Acceptable Quality Level Method of Assessment
Security OWASP Application Security Verification Standard 4.0, Level 2 Code submitted must be free of medium- and high-level static and dynamic security vulnerabilities Clean tests from a static testing SaaS (such as npm audit) and from ZAP, along with documentation explaining any false positives

QASP: https://docs.google.com/document/d/1s-PJSdX43_DMAcXYalG9Upm31XvWCp31j_QGCzFJ7qY/edit

@jpmckinney jpmckinney transferred this issue from open-contracting/standard-maintenance-scripts Apr 16, 2021
@jpmckinney jpmckinney changed the title Consider adding CodeQL workflows QASP: Security Apr 16, 2021
@jpmckinney jpmckinney added the implementation Relating to policy implementation label Apr 16, 2021
jpmckinney added a commit that referenced this issue Apr 16, 2021
@jpmckinney jpmckinney changed the title QASP: Security QASP: Add Security automation Apr 16, 2021
@jpmckinney
Copy link
Member Author

SSRF comes up in a few tools (Data Review Tool, Spoonbill).

To check for all requests across repositories:

\brequests\.(?!(adapters|codes|org)\b)[a-z]|\bsession\.(?!(add|commit|expire_all|flush|mount|query|rollback)\b)\w

I've added Security: comments (or .. attention:: docs mentioning SSRF) where relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementation Relating to policy implementation
Projects
None yet
Development

No branches or pull requests

1 participant