Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert documentation to MyST Markdown and new theme #1190

Open
3 of 9 tasks
choldgraf opened this issue Feb 1, 2021 · 9 comments
Open
3 of 9 tasks

Convert documentation to MyST Markdown and new theme #1190

choldgraf opened this issue Feb 1, 2021 · 9 comments
Assignees
Labels
Focus - Design Requiring design work

Comments

@choldgraf
Copy link
Contributor

choldgraf commented Feb 1, 2021

This is a meta-issue to track conversion of documentation syntax to use MyST Markdown. It may grow or shrink as more focused issues pop up during initial conversion so I'll track them here.

After this is mostly done

Note - Chris is not sure if the following are in scope for him or not...he suspects somebody else will be more efficient in doing it than he is

@choldgraf choldgraf changed the title Convert documentation to MyST Markdown [DOC] Convert documentation to MyST Markdown Feb 1, 2021
@choldgraf choldgraf changed the title [DOC] Convert documentation to MyST Markdown [MyST] Convert documentation to MyST Markdown Feb 1, 2021
@choldgraf
Copy link
Contributor Author

Also note - I'm going to prefix all of these issues with [MyST] to help differentiate them from others, since I cannot add tags etc myself.

@choldgraf
Copy link
Contributor Author

@jpmckinney do you prefer to have one mega-PR that does all of the changes at once, or is it OK to break this into several smaller PRs that get merged over time?

@jpmckinney jpmckinney added the Focus - Design Requiring design work label Feb 1, 2021
@jpmckinney
Copy link
Member

I've changed your role to Maintain, so you should be able to create/add labels. An issue prefix is also fine.

I have no preference in terms of PR size. For larger PRs, I sometimes read one commit diff at a time when reviewing.

@jpmckinney
Copy link
Member

jpmckinney commented Feb 12, 2021

Follow-up for this issue:

  • Update selector(s) in util/add_translation_notes.py

Small cleanup that can be done in later PRs:

After theme change, follow-up to replicate search features:

@choldgraf
Copy link
Contributor Author

Hey @jpmckinney - I've updated the top comment with a few more of the to-dos that we discussed. I think that a lot of the eval-rst blocks are converted, and I'm wondering what you'd prefer that we prioritize moving forward. E.g., do you prefer that we finish up the MyST conversion to 100%, or better to try out new themes etc?

@jpmckinney
Copy link
Member

I think better to try out new themes. And yes, I'll do the two search-related bullets :)

@choldgraf
Copy link
Contributor Author

choldgraf commented Mar 12, 2021

@jpmckinney we just released a new version of the PyData theme: https://github.com/pydata/pydata-sphinx-theme/releases

I think that this should make it a bit easier to customize and such. When trying out a new theme for these docs, would you like to try that (because it is a topbar-based theme) or start with the Sphinx Book Theme (https://sphinx-book-theme.readthedocs.io/) ?

My intuition is that if you'd like a top-bar for navigation eventually, then it will be easier to start with the PyData theme and customize, rather than start w/ the Book theme and add a top-bar. Strong preferences?

@jpmckinney
Copy link
Member

Thanks for the explanation and updates! Let's go with the PyData theme 👍

@jpmckinney
Copy link
Member

@jpmckinney jpmckinney self-assigned this Jun 7, 2023
@jpmckinney jpmckinney changed the title [MyST] Convert documentation to MyST Markdown Convert documentation to MyST Markdown and new theme May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus - Design Requiring design work
Projects
Status: Backlog
Development

No branches or pull requests

2 participants