Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FluentAssertions #353

Open
askpt opened this issue Jan 31, 2025 · 3 comments · May be fixed by #361
Open

Remove FluentAssertions #353

askpt opened this issue Jan 31, 2025 · 3 comments · May be fixed by #361
Assignees
@kylejuliandev
Labels
dependencies Updating a dependency good first issue Good for newcomers tests Improvement or additions to test suite

Comments

@askpt
Copy link
Member

askpt commented Jan 31, 2025 •
edited
Loading

Description

FluentAssertions is now a paid library starting with version 8. We should consider transitioning to another library like shouldly or use the assertions instead.

More information
@askpt askpt added dependency good first issue Good for newcomers tests Improvement or additions to test suite dependencies Updating a dependency and removed dependency labels Jan 31, 2025
@beeme1mr
Copy link
Member

That looks like a messy situation. At least we can continue to use v7 for now.

@kylejuliandev
Copy link
Contributor

I can pick this up if no one else has started on it.

@askpt
Copy link
Member Author

askpt commented Jan 31, 2025

I can pick this up if no one else has started on it.

Thanks @kylejuliandev. Assigned the issue to you

@kylejuliandev kylejuliandev linked a pull request Jan 31, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylejuliandev kylejuliandev

Labels
dependencies Updating a dependency good first issue Good for newcomers tests Improvement or additions to test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove FluentAssertions kylejuliandev/dotnet-sdk
3 participants
@beeme1mr @askpt @kylejuliandev