-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JMH Benchmarks for the critical code paths #1146
Comments
Yes this is a great idea. We could run these as part of the SDK CI. We may also want to add something similar to the contribs eventually, though there it will be up to each component owner what constitutes adequate performance. |
I should start correctly reading comments. Sorry for this. Well, I am fine for now. Some verification would be good, or some persistence of at least the latest results, so we can at least verify from time to time. Furthermore, it would be cool if we found a tool where we can add this metric correctly to draw nice graphs and see how the performance evolves. But without a proper tool to display the data, I don't see a benefit in adding it to the CI. |
Our tool is excellent, but more and more people are using it. We already received internal information, that some code paths tend to be hotspots, especially
structure
operations.Evaluating this without a proper test harness around it is hard; hence, it might be a good idea to add a JMH Suite to our tests for verification and to allow us to spot hotspots earlier in the future.
The text was updated successfully, but these errors were encountered: