Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate the release process with Release Please #4

Closed
4 of 5 tasks
beeme1mr opened this issue Aug 9, 2023 · 7 comments · Fixed by #57
Closed
4 of 5 tasks

Automate the release process with Release Please #4

beeme1mr opened this issue Aug 9, 2023 · 7 comments · Fixed by #57

Comments

@beeme1mr
Copy link
Member

beeme1mr commented Aug 9, 2023

Tasks

  1. beeme1mr
@vahidlazio
Copy link
Collaborator

@toddbaert @beeme1mr we need admin access to the repos in order to add github actions secrets etc. we should probably be added here i guess?

@toddbaert
Copy link
Member

@toddbaert @beeme1mr we need admin access to the repos in order to add github actions secrets etc. we should probably be added here i guess?

None of the "admin" groups are populated per repo. To keep secrets minimally shared, this is restricted to the org admins (the TC and GC). If you let us know what secrets/app you need, we'll be happy to set them up for you.

@beeme1mr
Copy link
Member Author

Sorry, I missed this notification. We can probably grant temporary admin access while the repo is being bootstrapped. I'll look into it tomorrow.

@vahidlazio
Copy link
Collaborator

@toddbaert @beeme1mr thanks both. we need at least github token in the secrets to integrate the "release please" action that you use in other repos.

@beeme1mr
Copy link
Member Author

Hey @vahidlazio, I've granted you admin permission while you set up the repo. You should be able to access the repo settings now.

By the way, tou shouldn't need to set the GITHUB_TOKEN. That's defined by GitHub automatically.

@vahidlazio
Copy link
Collaborator

@beeme1mr thanks for the permissions, it helped a lot for testing different scenarios for release please plugin. however i wanted to add more things to the releases and upload an aar file to the created release. i used upload_url from the output of the create_release step and it seems like it can't pick it up. I ended up removing it here since it's not critical thing to have in the releases but it would be nice if we could find out what's going on and why it fails.

@beeme1mr
Copy link
Member Author

Hey @vahidlazio, I'm out of the office today but I'll look into it when I'm back.

nicklasl added a commit that referenced this issue Oct 16, 2023
Fixes #4 

Signed-off-by: Nicklas Lundin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants