Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not directly related to this PR, but seeing this written out makes me feel it is a little verbose. Perhaps it's a configure inside a configure that feels like a code smell? #10

Open
josecolella opened this issue Jan 23, 2023 · 0 comments

Comments

@josecolella
Copy link
Collaborator

          Not directly related to this PR, but seeing this written out makes me feel it is a little verbose. Perhaps it's a configure inside a configure that feels like a code smell?

How about exposing the options as a kwargs / hash?

    config.provider = OpenFeature::FlagD::Provider.configure(
        host: "localhost"
        port: 8013
        tls: true
        provider_config: './ca.pem'
    )

It might be useful to offer both?

Originally posted by @technicalpickles in #8 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant