Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend type signatures #53

Closed
mschoenlaub opened this issue Sep 3, 2023 · 3 comments
Closed

Amend type signatures #53

mschoenlaub opened this issue Sep 3, 2023 · 3 comments

Comments

@mschoenlaub
Copy link
Contributor

This SDK has one type signature. The current state of type signature is more of a PoC, I guess.
@mschoenlaub mschoenlaub mentioned this issue Sep 5, 2023
Closed
@technicalpickles
Copy link
Collaborator

The current state of type signature is more of a PoC, I guess.

Correct. Mentioned on #58 it was part of the autogenerated gem. I'm more inclined to remove than make it up to date.

@maxveldink
Copy link
Member

FWIW, I also favor delaying sigs until we're spec-compliant.

@technicalpickles technicalpickles mentioned this issue Sep 13, 2023
Closed
@technicalpickles
Copy link
Collaborator

Created #66 to track deleting the existing signatures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add type signatures and type checker for CI mschoenlaub/ruby-sdk
3 participants
@technicalpickles @mschoenlaub @maxveldink