-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-evaluate OpenFeature
file naming
#71
Comments
I am highly in favor of keeping the module named I came across a similar issue where in the inital RBS file the module was named |
Our naming conventions say both As we aren't yet at a 1.0, this is a good time to make breaking changes (if needed). I won't weigh in on what specifically is more "rubyesque". |
Created #90 to address the file change! One last thing would be renaming the entire package. Currently, it's |
While working on #72, I encountered a rule violation around spec naming. I believe this was because the files were named
openfeature
while the constant we're defining isOpenFeature
. In addition to violating the rule, this naming convention is surprising, and I'd expect the files to be namedopen_feature
. This would also be an issue if we switched to the Zeitwerk autoloader.I'm curious about the naming choice and if we'd be open to renaming, especially while we do not have a major version.
The text was updated successfully, but these errors were encountered: