Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update constructions #1267

Open
jelgerjansen opened this issue May 5, 2022 · 3 comments
Open

Update constructions #1267

jelgerjansen opened this issue May 5, 2022 · 3 comments
Assignees
@jelgerjansen

Comments

@jelgerjansen
Copy link
Contributor

Some constructions within IDEAS.Buildings.Data.Constructions should be updated and some seem to be obsolete.
@jelgerjansen
Copy link
Contributor Author

@Mathadon there are two different floors which can be used in combination with a floor heating system (FloorOnGround and InsulatedFloorHeating), but the latter seems to be a floor not suitable for a floor heating system (barely insulated and furthermore locGain seems to be wrong). I propose we update the documentation for FloorOnGround indicating this is not suitable in combination with a floor heating system?

@jelgerjansen
Copy link
Contributor Author

After an internal discussion it is decided to remove FloorOnGround and replace it by InsulatedFloorHeating.
Furthermore, a construction should be added to represent a floor between two zones on top of each other.

@jelgerjansen jelgerjansen self-assigned this Jun 2, 2022
@jelgerjansen
Copy link
Contributor Author

Let's wait implementing this till the CI is up and running (#1316) to not break any code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jelgerjansen jelgerjansen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jelgerjansen