Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional model version #1

Closed
zevisert opened this issue Nov 26, 2023 · 1 comment · Fixed by #10
Closed

Optional model version #1

zevisert opened this issue Nov 26, 2023 · 1 comment · Fixed by #10

Comments

@zevisert
Copy link
Contributor

The descriptions for "Model Ready" and "Model Metadata" in both the REST and gRPC specifications claim that the model version is optional. Is this true? If so, the specification should report it's optionality in more than a comment/description (optional in proto3 and required: false in openAPI). If the version is optional in the REST protocol, should there instead be another versionless route instead of eg, '/v2/models/${MODEL_NAME}/versions/${MODEL_VERSION}/ready'?

// The version of the model to check for readiness. If not given the
// server will choose a version based on the model and internal policy.
string version = 2;

// The version of the model to check for readiness. If not given the
// server will choose a version based on the model and internal policy.
string version = 2;

description: The “model ready” health API indicates if a specific model is ready for inferencing. The model name and (optionally) version must be available in the URL. If a version is not provided the server may choose a version based on its own policies.

description: 'The per-model metadata endpoint provides information about a model. A model metadata request is made with an HTTP GET to a model metadata endpoint. In the corresponding response the HTTP body contains the [Model Metadata Response JSON Object](#model-metadata-response-json-object) or the [Model Metadata Response JSON Error Object](#model-metadata-response-json-error-object). The model name and (optionally) version must be available in the URL. If a version is not provided the server may choose a version based on its own policies or return an error.'


@zevisert
Copy link
Contributor Author

RPC needs optionality for it's requests too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant