From ff1be5c61181ca3c2167a0f1043595a7a85a1d33 Mon Sep 17 00:00:00 2001
From: Ashish Gupta <ashish@getcollate.io>
Date: Wed, 22 Jan 2025 13:11:25 +0530
Subject: [PATCH] fix the richTextEditor output in case on no data save

---
 .../Modals/ModalWithMarkdownEditor/ModalWithMarkdownEditor.tsx | 3 +--
 .../common/RichTextEditor/RichTextEditor.interface.ts          | 2 +-
 .../ui/src/components/common/RichTextEditor/RichTextEditor.tsx | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Modals/ModalWithMarkdownEditor/ModalWithMarkdownEditor.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Modals/ModalWithMarkdownEditor/ModalWithMarkdownEditor.tsx
index d9638f795d1b..29fd67ac48ce 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Modals/ModalWithMarkdownEditor/ModalWithMarkdownEditor.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Modals/ModalWithMarkdownEditor/ModalWithMarkdownEditor.tsx
@@ -41,8 +41,7 @@ export const ModalWithMarkdownEditor: FunctionComponent<ModalWithMarkdownEditorP
       if (markdownRef.current) {
         setIsLoading(true);
         try {
-          const content =
-            markdownRef.current?.getEditorContent?.()?.trim() ?? '';
+          const content = markdownRef.current?.getEditorContent?.()?.trim();
           await onSave?.(content);
         } catch (error) {
           showErrorToast(error as AxiosError);
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/RichTextEditor/RichTextEditor.interface.ts b/openmetadata-ui/src/main/resources/ui/src/components/common/RichTextEditor/RichTextEditor.interface.ts
index dadd68a5cc56..0f6d2dc13f8d 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/common/RichTextEditor/RichTextEditor.interface.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/components/common/RichTextEditor/RichTextEditor.interface.ts
@@ -40,5 +40,5 @@ export interface RichTextEditorProp extends HTMLAttributes<HTMLDivElement> {
 }
 
 export interface EditorContentRef {
-  getEditorContent: () => string;
+  getEditorContent: () => string | undefined;
 }
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/RichTextEditor/RichTextEditor.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/RichTextEditor/RichTextEditor.tsx
index 495c8f35c7f8..1c9e9221df9f 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/common/RichTextEditor/RichTextEditor.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/common/RichTextEditor/RichTextEditor.tsx
@@ -47,7 +47,7 @@ const RichTextEditor = forwardRef<EditorContentRef, RichTextEditorProp>(
         const htmlContent = editorRef.current?.editor?.getHTML() ?? '';
         const backendFormat = formatContent(htmlContent, 'server');
 
-        return backendFormat;
+        return backendFormat === '<p></p>' ? undefined : backendFormat;
       },
     }));