Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$LDFLAGS lost building fortran on mac #12719

Closed
minrk opened this issue Jul 29, 2024 · 0 comments · Fixed by #12720
Closed

$LDFLAGS lost building fortran on mac #12719

minrk opened this issue Jul 29, 2024 · 0 comments · Fixed by #12720

Comments

@minrk
Copy link
Contributor

minrk commented Jul 29, 2024

Thank you for taking the time to submit an issue!

Background information

What version of Open MPI are you using? (e.g., v4.1.6, v5.0.1, git branch name and hash, etc.)

v5.0.4, v5.0.5

Describe how Open MPI was installed (e.g., from a source/distribution tarball, from a git clone, from an operating system distribution package, etc.)

build from dist tarball for 5.0.4 and 5.0.5 using conda-forge compilers.

Please describe the system on which you are running

  • Operating system/version: macOS 14.5
  • Computer hardware: m1 (ARM)
  • Network type: N/A

Details of the problem

Our builds of openmpi rely on $LDFLAGS to successfully link -lgfortran, at least in the cross compiling configuration. However, #12650 has a typo where LDFLAGS is saved in $LDFLAGS_save_xcode but restored from $LDFLAGS_xcode_save, which is never set, and thus empty. This has the effect that after this bit of configuration is run, $LDFLAGS is lost.

Fixing the variable names to match each other fixes the failing builds, as seen here with this patch.

@minrk minrk changed the title $LDFLAGS lost building on mac $LDFLAGS lost building fortran on mac Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants