From 7429d70bb2b7f688df71dd0f35d49682f3597fe0 Mon Sep 17 00:00:00 2001 From: Martijn van der Ploeg <73637849+martijnvdp@users.noreply.github.com> Date: Wed, 4 Sep 2024 03:40:04 +0200 Subject: [PATCH] fix: vap error logging for rego only templates (#3520) Signed-off-by: martijnvdp Co-authored-by: Jaydipkumar Arvindbhai Gabani --- .../constrainttemplate/constrainttemplate_controller.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/constrainttemplate/constrainttemplate_controller.go b/pkg/controller/constrainttemplate/constrainttemplate_controller.go index cfc728eacac..a9dbb7cccea 100644 --- a/pkg/controller/constrainttemplate/constrainttemplate_controller.go +++ b/pkg/controller/constrainttemplate/constrainttemplate_controller.go @@ -379,7 +379,7 @@ func (r *ReconcileConstraintTemplate) Reconcile(ctx context.Context, request rec return reconcile.Result{}, err } generateVap, err := constraint.ShouldGenerateVAP(unversionedCT) - if err != nil || !errors.Is(err, celSchema.ErrCodeNotDefined) { + if err != nil && !errors.Is(err, celSchema.ErrCodeNotDefined) { logger.Error(err, "generateVap error") } logger.Info("generateVap", "r.generateVap", generateVap)