Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup overlapping codes for MiR/FM adapter #34

Open
xiyuoh opened this issue Jun 1, 2023 · 0 comments
Open

Cleanup overlapping codes for MiR/FM adapter #34

xiyuoh opened this issue Jun 1, 2023 · 0 comments
Assignees

Comments

@xiyuoh
Copy link
Member

xiyuoh commented Jun 1, 2023

Following the conversation in #33, currently there is a lot of code overlap between the RobotCommandHandle and fleet_adapter for both MiR and MiRFM adapters. There should be a base class for these codes so that the API classes can be passed to each adapter as necessary, plus there will not be a need for rewriting common functions or updating both scripts whenever there are updates.

@xiyuoh xiyuoh self-assigned this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant