[Bug]: Problem building Docker image of rmf

[Villy01]

Before proceeding, is there an existing issue or discussion for this?

• I have done a search for similar issues and discussions.

OS and version

Ubuntu 23.04

Open-RMF installation type

Source build

Other Open-RMF installation methods

No response

Open-RMF version or commit hash

2.3.0

ROS distribution

Jazzy

ROS installation type

Source build

Other ROS installation methods

No response

Package or library, if applicable

No response

Description of the bug

I have a problem building the Docker image of rmf. I've alreay built the builder image, set correctly ARG BUILDER in the rmf Dockerfile (i say this because the instruction using that ARG execute correctly, while the one generating the problem doesn't need it, so i don't think is a dependences' error) and now i'm tryng to build the rmf image but i get 2 error. From log i can see the error is in this Dockerfile instruction:

RUN . /opt/ros/$ROS_DISTRO/setup.sh \ && colcon build --mixin clang lld --merge-install --install-base /opt/rmf --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-skip rmf_traffic_editor_test_maps

This is the terminal log:

First error log

#0 1051.1 --- stderr: rmf_task_ros2
#0 1051.1 /ws/src/rmf/rmf_ros2/rmf_task_ros2/src/rmf_task_ros2/Dispatcher.cpp:547:9: error: no viable conversion from 'Init_BidNotice_dry_run' to 'bidding::BidNoticeMsg' (aka 'BidNotice_<std::allocator<void>>')
#0 1051.1   547 |         rmf_task_msgs::build<bidding::BidNoticeMsg>()
#0 1051.1       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#0 1051.1   548 |         .request(task_request_json.dump())
#0 1051.1       |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#0 1051.1   549 |         .task_id(task_id)
#0 1051.1       |         ~~~~~~~~~~~~~~~~~
#0 1051.1   550 |         .time_window(bidding_time_window));
#0 1051.1       |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#0 1051.1 /opt/rmf/include/rmf_task_msgs/rmf_task_msgs/msg/detail/bid_notice__struct.hpp:39:8: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'Init_BidNotice_dry_run' to 'const BidNotice_<allocator<void>> &' for 1st argument

Second error log

#0 1051.1 /ws/src/rmf/rmf_ros2/rmf_task_ros2/src/rmf_task_ros2/Dispatcher.cpp:610:7: error: no viable conversion from 'Init_BidNotice_dry_run' to 'bidding::BidNoticeMsg' (aka 'BidNotice_<std::allocator<void>>')
#0 1051.1   610 |       rmf_task_msgs::build<bidding::BidNoticeMsg>()
#0 1051.1       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#0 1051.1   611 |       .request(task_request.dump())
#0 1051.1       |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#0 1051.1   612 |       .task_id(task_id)
#0 1051.1       |       ~~~~~~~~~~~~~~~~~
#0 1051.1   613 |       .time_window(bidding_time_window));
#0 1051.1       |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#0 1051.1 /opt/rmf/include/rmf_task_msgs/rmf_task_msgs/msg/detail/bid_notice__struct.hpp:39:8: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'Init_BidNotice_dry_run' to 'const BidNotice_<allocator<void>> &' for 1st argument

Final building's error message

------
Dockerfile:19
--------------------
  18 |     
  19 | >>> RUN . /opt/ros/$ROS_DISTRO/setup.sh \
  20 | >>>   && colcon build --mixin clang lld --merge-install --install-base /opt/rmf --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-skip rmf_traffic_editor_test_maps
  21 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c . /opt/ros/$ROS_DISTRO/setup.sh   && colcon build --mixin clang lld --merge-install --install-base /opt/rmf --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-skip rmf_traffic_editor_test_maps" did not complete successfully: exit code: 2

Steps to reproduce the bug

1. Build the builder image
2. Set ARG BUILDER in the rmf Dockerfile as the builder image
3. Build the rmf image

Expected behavior

No response

Actual behavior

No response

Additional information or screenshots

No response

[akash-roboticist]

Thanks for re-filing the bug; I re-ran the CI and see the error in the build logs for the rmf image.

[akash-roboticist]

Update -

• The issue building the rmf image was related to an upstream change in rmf_internal_msgs and has been addressed with this PR - Do not update assignments if bid notice is for a dry run rmf_ros2#401 . With this, the CI for rmf image is green.
• There is however an update needed to the pnpm lockfile in rmf-web, and is being adressed by the PR Update pnpm lock file to handle patchedDependencies difference rmf-web#1048

[akash-roboticist]

With above PRs merged, all images are verified to be building successfully via the latest build