Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert OPENTELEMETRYBOT_GITHUB_TOKEN org secret to fine-grained PAT #1549

Open
trask opened this issue Jun 15, 2023 · 10 comments
Open

Convert OPENTELEMETRYBOT_GITHUB_TOKEN org secret to fine-grained PAT #1549

trask opened this issue Jun 15, 2023 · 10 comments
Assignees
Labels
area/project-infra Non-GitHub project infra (DockerHub, etc.)

Comments

@trask
Copy link
Member

trask commented Jun 15, 2023

See motivation at #1503 (comment).

I will be pinging the repos which are already using the org secret to let them know we'll be switching the org secret over to a fine-grained PAT.

Current target is to make this switch on Wed, June 28 (I'm on vacation next week so want to wait until afterwards in case any issues).

After we switch the org secret over to the fine-grained PAT, I'll revoke the old PAT.

@trask trask self-assigned this Jun 15, 2023
@trask
Copy link
Member Author

trask commented Jun 15, 2023

pinging all maintainers for repos that are using OPENTELEMETRYBOT_GITHUB_TOKEN

so far, the fine-grained token has only the permissions in the screenshot below.

this has been enough for the Java repos, but we aren't using @opentelemetrybot to update issues, so if you have any automation that requires updating issue (or anything else besides creating/updating PRs) let me know

image

@pavolloffay
Copy link
Member

pavolloffay commented Jun 15, 2023

@trask thanks for letting us know.

In the operator repo we use the bot to sync some 3rd party GH repos and open PRs (similar to what is done in the java auto-instrumentation to submit PRs to the operator repo). Will that continue to work?

@codeboten
Copy link
Contributor

After looking at the use of this token in the collector & collector-contrib repos, i believe the workflows will continue to work for those repos with the fine grained PAT.

@pellared
Copy link
Member

@trask
Copy link
Member Author

trask commented Jul 1, 2023

@pavolloffay I think you will need more access for that usage.

I've created a separate fine-grained PAT that I think will give you the access you need to opentelemetrybot's forks (see screenshot below).

@open-telemetry/technical-committee what do you think about storing this new fine-grained PAT in an org secret scoped to only opentelemetry-operator repository, named OPENTELEMETRYBOT_OPERATOR_FORKS_GITHUB_TOKEN.

image

@trask
Copy link
Member Author

trask commented Jul 6, 2023

@open-telemetry/technical-committee what do you think about storing this new fine-grained PAT in an org secret scoped to only opentelemetry-operator repository, named OPENTELEMETRYBOT_OPERATOR_FORKS_GITHUB_TOKEN.

@arminru what do you think?

@arminru
Copy link
Member

arminru commented Jul 6, 2023

@open-telemetry/technical-committee what do you think about storing this new fine-grained PAT in an org secret scoped to only opentelemetry-operator repository, named OPENTELEMETRYBOT_OPERATOR_FORKS_GITHUB_TOKEN.

@arminru what do you think?

@trask +1 on using the fine-grained tokens scoped to individual repos instead of the org-wide OTel Bot token. I'll reach out to you directly to set it up.

@trask
Copy link
Member Author

trask commented Jul 6, 2023

@arminru and I discussed on slack and agreed for now at least that we would share repo-specific tokens directly with maintainers of those repos instead of adding them as repo-scoped org secrets

@pavolloffay I'll send you a one-time link for the PAT that can be used for the above operator workflows

@ocelotl
Copy link

ocelotl commented Jul 27, 2023

@trask In OTel Python we only use OPENTELMETRYBOT_GITHUB_TOKEN for our release process (you commited the .yml files yourself). We made a change to use OPENTELMETRYBOT_GITHUB_TOKEN afterwards.

@ocelotl
Copy link

ocelotl commented Jul 27, 2023

In Pyhton we only use this token in our release process to create release PRs. We should be ok 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/project-infra Non-GitHub project infra (DockerHub, etc.)
Projects
Development

No branches or pull requests

6 participants