-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should X-Ray Trace exporter not create Segment for Consumer SpanKind? #20267
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Hi @krissrex - thanks for raising this. This issue has been reported here as well: aws-observability/aws-otel-collector#1773 We will be taking a look at fixing this as soon as possible and post an update when we can. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners: See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
exporter/awsxray
What happened?
Description
The current AWS X-Ray exporter will create subsegments of all spans but Server.
For an application using messaging, like an AWS SQS consumer, it seems correct to use SpanKind Consumer https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#spankind .
I try to connect the consumer to a parent using the
io.opentelemetry.contrib:opentelemetry-aws-xray-propagator:1.23.0-alpha
like this andspan.setParent
.However, X-Ray will see these as sub-segments, instead of remotes.
Is this correct?
Is producer-consumer only intended to be internally in an application, not for applications communicating events via SQS?
Steps to Reproduce
AWSTraceHeader
.where I get a parent like this:
Expected Result
Segments in xray called
myEvent receive
.Actual Result
Subsegment nested under some other service, making it look internal.
Collector version
0.26.1
Environment information
Environment
OpenTelemetry Collector configuration
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: