Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric instrumentation for SQLClient #1738

Open
cijothomas opened this issue Oct 19, 2021 · 4 comments
Open

Metric instrumentation for SQLClient #1738

cijothomas opened this issue Oct 19, 2021 · 4 comments
Assignees
Labels
comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient enhancement New feature or request

Comments

@cijothomas
Copy link
Member

Similar to: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInMetricsListener.cs

No semantic conventions exist as of today for db, but can still do a basic sql call duration metric. The instrumentations are not stable release anyway, so we can make changes as spec evolves. The goal is to get some metrics flowing automatically for libraries which already have traces enabled.

@cijothomas cijothomas added the enhancement New feature or request label Oct 19, 2021
@cijothomas
Copy link
Member Author

@pantosha
Copy link

pantosha commented Nov 3, 2023

@cijothomas
Copy link
Member Author

https://github.com/open-telemetry/opentelemetry-specification/pull/2070/files

@cijothomas are you going to merge this PR?

I am not.

@pantosha
Copy link

pantosha commented Nov 3, 2023

Oh, sorry, I missed that this is a link to a pull request with a convention.
Thank you for the fast answer 😊

@reyang reyang transferred this issue from open-telemetry/opentelemetry-dotnet May 13, 2024
@reyang reyang added the comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants