Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spring-boot.md #3835

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Update spring-boot.md #3835

merged 4 commits into from
Jan 26, 2024

Conversation

XiaotianZha
Copy link
Contributor

Without <scope>import</scope>, there will be an error
Could not find artifact io.opentelemetry.instrumentation:opentelemetry-spring-boot-starter:jar:unknown

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Without `<scope>import</scope>`, there will be an error 
Could not find artifact io.opentelemetry.instrumentation:opentelemetry-spring-boot-starter:jar:unknown
@XiaotianZha XiaotianZha requested review from a team January 21, 2024 12:27
Copy link

linux-foundation-easycla bot commented Jan 21, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@cartermp
Copy link
Contributor

@open-telemetry/javascript-approvers PTAL!

@cartermp cartermp added the sig-approval-missing Co-owning SIG didn't provide an approval label Jan 21, 2024
@JamieDanielson
Copy link
Member

@open-telemetry/java-approvers

@svrnm svrnm added the sig:java label Jan 22, 2024
@cartermp
Copy link
Contributor

cartermp commented Jan 22, 2024

literally happens every month, god dammit

@svrnm svrnm merged commit 3136a9e into open-telemetry:main Jan 26, 2024
14 checks passed
@svrnm
Copy link
Member

svrnm commented Jan 26, 2024

thank you @XiaotianZha !

@XiaotianZha
Copy link
Contributor Author

thank you @XiaotianZha !

You are welcom! It's my first PR for open source project, It's means a lot to me!

@XiaotianZha XiaotianZha deleted the patch-2 branch January 26, 2024 13:06
@svrnm svrnm removed the sig-approval-missing Co-owning SIG didn't provide an approval label Jan 26, 2024
@svrnm
Copy link
Member

svrnm commented Jan 26, 2024

@XiaotianZha Awesome, congratulations then to your first PR to an OSS project, and thank you for picking our project. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants