Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle webhook errors #1575

Closed
smashah opened this issue Apr 12, 2021 · 3 comments
Closed

Gracefully handle webhook errors #1575

smashah opened this issue Apr 12, 2021 · 3 comments
Labels
PRIORITY Fast track for BMAC Members only.

Comments

@smashah
Copy link
Member

smashah commented Apr 12, 2021

For example, when a webhook.site URL is deleted. It responds with a 404. This actually crashes the process when eventMode: true (it is true by default now).

Eventually, the process will need to retry failed requests via config options - e.g retryOnWebhookFailure

@owa-gh-bot owa-gh-bot bot added the PRIORITY Fast track for BMAC Members only. label Apr 12, 2021
@smashah
Copy link
Member Author

smashah commented Apr 13, 2021

@github-actions run

⚡ Release! ⚡
(async () => {
function exec(cmd) {
  console.log(execSync(cmd).toString());
}

// Config
const gitUserEmail = "github-actions[bot]@users.noreply.github.com";
const gitUserName = "github-actions[bot]";

exec(`echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" > .npmrc`);
exec(`git config --global user.email "${gitUserEmail}"`);
exec(`git config --global user.name "${gitUserName}"`);
exec(`npm i -D`);
exec(`npm run release-ci`);

//comment on the issue
var result = execSync(`npx auto-changelog -o ./tempchangelog.txt --commit-limit false --template ./compact-keepachangelog.hbs --stdout`).toString();

    await postComment(result);

//create changelog image
exec(`npm run release-image`);
exec(`git commit -a -m 'updated release-image'`);
exec(`git push --force`);
  })();

@smashah
Copy link
Member Author

smashah commented Apr 13, 2021

Changelog

🚀 Release 3.10.14 (2021-04-13)

  • build(deps): bump optional-require from 1.0.2 to 1.0.3 #1576
  • build(deps-dev): bump marked from 2.0.1 to 2.0.3 #1577
  • build(deps-dev): bump release-it from 14.5.1 to 14.6.1 #1578
  • build(deps-dev): bump eslint from 7.23.0 to 7.24.0 #1579
  • build(deps): bump ts-json-schema-generator from 0.89.2 to 0.89.3 #1580
  • Release 3.10.14 84b7674
  • 🐛 fix ws reverse proxy detection on popup 00ed003
  • ✨ feat: added batteryLow to client.healthCheck 966bbfc
  • 🐛 ignore webhook errors for now Gracefully handle webhook errors #1575 d211eb5

@smashah
Copy link
Member Author

smashah commented Apr 13, 2021

complete retries and backoff later #659

@smashah smashah closed this as completed Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PRIORITY Fast track for BMAC Members only.
Projects
None yet
Development

No branches or pull requests

1 participant