Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Fix cross platform libvip install annoyances by replacing sharp with lipo #875

Closed
2 tasks
smashah opened this issue Sep 30, 2020 · 3 comments
Closed
2 tasks
Labels

Comments

@smashah
Copy link
Member

smashah commented Sep 30, 2020

Sharp isn't a core part of the library and honestly causes more headache than it solves for most people. Lipo is a drop-in replacement for sharp that basically offloads all conversions to an API - or a self-hosted central sharp implementation. This should save 40+mb from install.

The only downside is that the api has rate limits per IP. This can be bypassed by manually setting up a lipo server.

Todo:

  • Replace Sharp with Lipo

  • Add lipo config options to config object

https://github.com/lipojs/lipo

Status: Blocked by https://github.com/lipojs/lipo/issues/18

@owa-gh-bot owa-gh-bot bot added the PRIORITY Fast track for BMAC Members only. label Sep 30, 2020
@smashah smashah added this to the v3 milestone Oct 2, 2020
@smashah smashah added BLOCKED and removed PRIORITY Fast track for BMAC Members only. labels Oct 3, 2020
@smashah
Copy link
Member Author

smashah commented Oct 7, 2020

Update. This will need a custom open-wa fork of lipo.

@joedutra
Copy link

joedutra commented Nov 8, 2020

I come to apologize and say that we have nothing against this, only that they accuse us of copying and we never copied anything, if someone copied it was when someone changed our lib, I apologize and the intention was not to be slandered anymore of copying something we worked on every day. just like you, we will not do that anymore.

@smashah smashah modified the milestones: v3, V4 Dec 22, 2020
@smashah smashah removed this from the V4 milestone Jan 13, 2021
@smashah
Copy link
Member Author

smashah commented Jan 13, 2021

Closing

Please see:

#659 (comment)

@smashah smashah closed this as completed Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants