Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAS : detailed-logging-is-on attribute is missing under response : schema of /core-model-1-4:control-construct and /v1/list-ltps-and-fcs #83

Closed
IswaryaaS opened this issue Mar 21, 2022 · 3 comments · Fixed by ManasaBM1/ApplicationPattern#1

Comments

@IswaryaaS
Copy link
Collaborator

While accessing services like /v1/list-ltps-and-fcs and /core-model-1-4:control-construct , these services responds data of list of operation-client(s) along with the actual data. Here, detailed-logging-is-on is an optional attribute which is present only in operation-client ltp instance of /v1/record-service-request of ExecutionAndTraceLog (*-0-0-1-op-c-0040).

In OAS, under schema specifications of /v1/list-ltps-and-fcs and /core-model-1-4:control-construct, under the path logical-termination-point --> layer-protocol --> operation-client ltp --> operation-client-interface-configuration specification , since the attribute "detailed-logging-is-on" is present only in one-instance among the operation-clients (an optional attribute), can we add it only under properties section(not in required section).

image

@IswaryaaS IswaryaaS added the bug Something isn't working label Mar 21, 2022
@openBackhaul
Copy link
Owner

Decision:

  • Martin will try to correct the Express framework's oas3/tools module, so it is properly executing the validation of the response, with in 5 working days max.
  • Prathiba will change the ApplicationPattern's code in such a way that the /v1/list-ltps-and-fcs service's response will not include the detailed-logging-is-on attribute.
  • Thorsten will change the TAC applications' specifications and the applicationPattern in such a way that the detailed-logging-is-on attribute will be part of the properties section (but not the required section!) of the /core-model-1-4:control-construct path.

@openBackhaul openBackhaul added implementation_to_be_changed and removed bug Something isn't working labels May 13, 2022
@MartinSunal
Copy link
Collaborator

MartinSunal commented May 26, 2022

Validation is working as described here:
bug-hunters/oas3-tools#43 (comment)
bug-hunters/oas3-tools#43 (comment)

That means we need to change res.end() to be res.json() or res.send() in all application controllers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment