Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide option for ''Remove edit source links' at loc drop command #734

Open
jfaltenbacher opened this issue Jul 12, 2024 · 2 comments
Open
Assignees

Comments

@jfaltenbacher
Copy link

jfaltenbacher commented Jul 12, 2024

Problem description

When handing over the translations via locdrop, the edit source links need to be removed manually.

Expected behavior

Provide an option to automatically remove 'Edit source' links either together with loc drop command, or as pre-/post function.

Steps to reproduce problem

@tomschr
Copy link
Collaborator

tomschr commented Aug 6, 2024

@jfaltenbacher Just to be clear:

  • The XML sources contain never these links. They only appear in HTML.
  • The SUSE stylesheets has an option to disable the links (use the title.icons parameter).

When you build HTML, pass the mentioned parameter on the command line:

$ daps -d YOUR_DC_FILE html --param="title.icons=0"

Unfortunately, daps locdrop doesn't provide a --param or --stringparam option.

Maybe it's more flexible to provide --param or --stringparam instead of a specific option?

@jfaltenbacher
Copy link
Author

jfaltenbacher commented Aug 7, 2024

the editurl tag is usually contained in the docmanager section in the MAIN[].xml :

<dm:docmanager xmlns:dm="urn:x-suse:ns:docmanager">
      <dm:editurl>https://github.com/SUSE/doc-sle/blob/main/xml/</dm:editurl>
    </dm:docmanager>

Just disabling would be ok for me, if sufficient.

If it is not possible to include this in the loc drop command, it would also be ok to have some other command/option to remove the links somehow automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants