Parse workflow's branch filters as strings

src/api/app/models/workflow.rb

@@ -1,4 +1,4 @@
-class Workflow
+class Workflow # rubocop:disable Metrics/ClassLength
   include ActiveModel::Model
   include WorkflowInstrumentation # for run_callbacks
   include WorkflowVersionMatcher
@@ -104,15 +104,23 @@ def event_matches_event_filter?
   def branch_matches_branches_filter?
     return true unless supported_filters.key?(:branches)
 
-    branches_only = filters[:branches].fetch(:only, [])
-    branches_ignore = filters[:branches].fetch(:ignore, [])
+    return true if branch_matches_branches_only_filter?
 
-    return true if branches_only.present? && branches_only.include?(workflow_run.target_branch)
-    return true if branches_ignore.present? && branches_ignore.exclude?(workflow_run.target_branch)
+    return true if branch_matches_branches_ignore_filter?
 
     false
   end
 
+  def branch_matches_branches_only_filter?
+    branches_only = filters[:branches].fetch(:only, []).map(&:to_s)
+    branches_only.present? && branches_only.include?(workflow_run.target_branch)
+  end
+
+  def branch_matches_branches_ignore_filter?
+    branches_ignore = filters[:branches].fetch(:ignore, []).map(&:to_s)
+    branches_ignore.present? && branches_ignore.exclude?(workflow_run.target_branch)
+  end
+
   # rubocop:disable Metrics/CyclomaticComplexity
   # Execute only if labeled or unlabeled
   def label_matches_labels_filter?

src/api/spec/fixtures/files/request_payload_github_pull_request_opened_branch_number.json

@@ -0,0 +1,27 @@
+{
+  "action": "opened",
+  "number": 1,
+  "pull_request": {
+    "number": 1,
+    "html_url": "http://github.com/something",
+    "base": {
+      "ref": "16.0",
+      "repo": {
+        "full_name": "openSUSE/repo123"
+      }
+    },
+    "head": {
+      "sha": "123456789"
+    }
+  },
+  "repository": {
+    "name": "hello_world",
+    "html_url": "https://github.com",
+    "owner": {
+      "login": "iggy"
+    }
+  },
+  "sender": {
+    "url": "https://api.github.com"
+  }
+}

src/api/spec/models/workflow_spec.rb

@@ -217,6 +217,19 @@
         subject.call
         expect(subject.steps.first).to have_received(:call)
       end
+
+      context 'the branches filter contains a number' do
+        let(:yaml) do
+          { 'steps' => [{ 'branch_package' => { 'source_project' => 'test-project', 'source_package' => 'test-package' } }],
+            'filters' => { 'branches' => { 'only' => [16.0, 'develop'] } } }
+        end
+        let(:request_payload) { file_fixture('request_payload_github_pull_request_opened_branch_number.json').read }
+
+        it 'the workflow runs' do
+          subject.call
+          expect(subject.steps.first).to have_received(:call)
+        end
+      end
     end
 
     context 'when the webhook event is not supported by the branches filter' do