Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require tests of bandwidth monitoring #8

Open
fno2010 opened this issue Oct 24, 2017 · 2 comments
Open

Require tests of bandwidth monitoring #8

fno2010 opened this issue Oct 24, 2017 · 2 comments
Assignees

Comments

@fno2010
Copy link
Member

fno2010 commented Oct 24, 2017

We do not test basic bandwidth monitoring function in either unit tests or integration tests. From my basic code review, it does not work in some special cases. For example, how can this line make sure the initial monitoring work?

We need somebody to check it and make sure it works.

@fno2010
Copy link
Member Author

fno2010 commented Nov 9, 2017

I think this line is incorrect and conducts the divide-zero exception. Because getSecond will always return 0. And I believe it also conducts issue #10.

fno2010 added a commit that referenced this issue Nov 9, 2017
Write capacity and availbw back to datastore.
So this patch should also fix #10.

Signed-off-by: jensenzhang <[email protected]>
fno2010 added a commit that referenced this issue Nov 9, 2017
Write capacity and availbw back to datastore.
So this patch should also fix #10.

Signed-off-by: jensenzhang <[email protected]>
@fno2010
Copy link
Member Author

fno2010 commented Nov 10, 2017

The quick fix cannot work because many node-connectors cannot update their duration properties (not sure it's the hardware issue or ODL issue):

"openflow:75096032357597:3401"
{
  "second": 0,
  "nanosecond": 0
}
"openflow:75096032357597:6201"
{
  "second": 0,
  "nanosecond": 0
}
"openflow:137432795454528:111"
{
  "second": 819660,
  "nanosecond": 527000000
}
"openflow:137432795454528:89"
{
  "second": 808576,
  "nanosecond": 769000000
}
"openflow:365545302427456:137"
{
  "second": 0,
  "nanosecond": 0
}
"openflow:365545302427456:225"
{
  "second": 0,
  "nanosecond": 0
}

A trade-off may be taking the timestamp in controller side (system time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants