Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

Scenes do not cancel their non intermediary actions when triggered via an intermediary one. #165

Open
2 of 3 tasks
DivineThreepwood opened this issue Jan 5, 2020 · 1 comment
Assignees
Labels

Comments

@DivineThreepwood
Copy link
Member

DivineThreepwood commented Jan 5, 2020

Bug can be reproduced when an scene is activated which for example changes the color of an entire room to red via the location unit. The lights keep the red color even when the scene is deactivated. Because the scene is not active the actions are not auto extended and canceled after the validation timeout occurs.

It seems like intermediary actions do not cancel their caused actions, therefore please validate:

  • why do the current unit test still succeed, since they should actually cover this scenario.
  • implement unit test to reproduce the issue
  • why are the causes not canceled?
@DivineThreepwood
Copy link
Member Author

test still succeeded because the unit test only test the affected devices and never the cancellation of impacted actions. I wrote a unit test testTestIntermediaryActionCancellationOnSceneDeactivation in SceneRemoteTest and reproduced the issue. Found already one bug in the SceneControllerImpl where an outdated action description was returned instead the new one with an updated impact action list. Therefore, the scenes where not able to cancel their impact. However, the test is still failing when all test of the test class are performed at once. In this case the impacted action are again not properly canceled. So issue still not fully solved.

DivineThreepwood added a commit that referenced this issue Jan 14, 2020
…ne containing the related action impact list. This bug inhibits the cancelation of intermediary action impacts and is related to issue #165
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant