Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error can re-import brc20 token even though the token is already in the wallet #194

Closed
1 task done
haiyenvu23 opened this issue Jun 19, 2024 · 2 comments · Fixed by #205
Closed
1 task done

Error can re-import brc20 token even though the token is already in the wallet #194

haiyenvu23 opened this issue Jun 19, 2024 · 2 comments · Fixed by #205
Assignees
@bluezdot

Comments

@haiyenvu23
Copy link

haiyenvu23 commented Jun 19, 2024 •
edited by bluezdot
Loading

Describe the bug

  • Error can re-import brc20 token even though the token is already in the wallet

Actual :

Image

Expect : Validate with token in wallet
@bluezdot bluezdot linked a pull request Jun 24, 2024 that will close this issue
[Issue-194] Fix bug duplicate import brc-20 #205
Merged
@bluezdot bluezdot removed a link to a pull request Jun 24, 2024
[Issue-194] Fix bug duplicate import brc-20 #205
Merged
@bluezdot bluezdot linked a pull request Jun 24, 2024 that will close this issue
[Issue-194] Fix bug duplicate import brc-20 #205
Merged
@bluezdot bluezdot assigned bluezdot and unassigned nampc1 Jun 24, 2024
@bluezdot
Copy link
Collaborator

bluezdot commented Jun 24, 2024 •
edited
Loading

  • BRC20: Check ticker has 4 or 5 bytes length to start validating BRC20 info
  • Rune: Check Rune ID includes : to start validating Rune info

@haiyenvu23
Copy link
Author

Version test : http://14.224.129.242:8900/s/doFcoEbDJZWmysR
Validation passed in case :

  • When re-import token
    Image

  • When import brc20 with 3 bytes

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bluezdot bluezdot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue-194] Fix bug duplicate import brc-20 openbitdev/OpenBit-Wallet
3 participants
@nampc1 @bluezdot @haiyenvu23