Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit-test is not really enabled #16

Open
leiyu-bytedance opened this issue Nov 16, 2021 · 0 comments
Open

unit-test is not really enabled #16

leiyu-bytedance opened this issue Nov 16, 2021 · 0 comments

Comments

@leiyu-bytedance
Copy link
Contributor

The tests/meson.build has below:

  have_boost_dbus = meson.get_compiler('cpp').has_header('dbus/connection.hpp')
  if have_boost_dbus
  test(...)
  endif

There is no 'dbus/connection.hpp' anyway, so the tests are not really enabled at all.

And the content in the test(...) is broken as well, e.g. the gtest dependency is incorrect, it shall be gtest_dep.
After fixing all the above, the unit test itself gets link failure because it does not include the expected cpp files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant