Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pwm sensor should have an association to the fan(s) not just the board #2

Open
pstrinkle opened this issue Oct 19, 2019 · 0 comments
Open

Pwm sensor should have an association to the fan(s) not just the board #2

pstrinkle opened this issue Oct 19, 2019 · 0 comments

Comments

@pstrinkle
Copy link
Member

Pwms control fan(s) but have no association property pointing to those fans.
bradbishop pushed a commit that referenced this issue May 5, 2022
@amboar
NVMeContext: Rework sensor removal concurrent to polling
b5d7a7f 
Concurrent removal of a sensor's configuration while the sensor list is
being iterated for polling can lead to undefined behaviour via access
through a deleted iterator:

    Program terminated with signal SIGSEGV, Segmentation fault.
    #0  std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count (__r=..., this=<optimised out>, this=<optimised out>, __r=...)
        at /usr/include/c++/11.2.0/bits/stl_list.h:224
    224     /usr/include/c++/11.2.0/bits/stl_list.h: No such file or directory.
    [Current thread is 1 (LWP 6649)]
    #0  std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count (__r=..., this=<optimised out>, this=<optimised out>, __r=...)
        at /usr/include/c++/11.2.0/bits/stl_list.h:224
    #1  std::__shared_ptr<NVMeSensor, (__gnu_cxx::_Lock_policy)2>::__shared_ptr (this=<optimised out>, this=<optimised out>)
        at /usr/include/c++/11.2.0/bits/shared_ptr_base.h:1152
    #2  std::shared_ptr<NVMeSensor>::shared_ptr (this=<optimised out>, this=<optimised out>) at /usr/include/c++/11.2.0/bits/shared_ptr.h:150
    #3  NVMeBasicContext::readAndProcessNVMeSensor (this=0x1ac8a90, iter=non-dereferenceable iterator for std::list) at ../git/src/NVMeBasicContext.cpp:299
    #4  0x004dd8b8 in NVMeBasicContext::readAndProcessNVMeSensor (this=0x1ac8a90, iter=non-dereferenceable iterator for std::list) at ../git/src/NVMeBasicContext.cpp:312
    #5  0x004dd8b8 in NVMeBasicContext::readAndProcessNVMeSensor (this=0x1ac8a90, iter=std::shared_ptr<NVMeSensor> (use count 26, weak count 28153871) = {get() = 0x1ad8db0})
        at ../git/src/NVMeBasicContext.cpp:312

Rework polling and sensor removal to uphold the requirement that the
iterator remains valid.

Signed-off-by: Andrew Jeffery <[email protected]>
Change-Id: I69b005fe3dad7ddf21d1762731f9cdfd2408cae1
bradbishop pushed a commit that referenced this issue Feb 8, 2024
@williamspatrick
meson: remove Boost TS executors
495aba1 
BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT enables the older Networking TS
executors instead of the newer "Standard Executors" and is not
necessary for io_uring.  Remove this option to use the newer execution
model.

Tested:

Confirmed the io_uring interfaces are still being used.
```
 (gdb) bt
 #0  0x00007ffff7dfba47 in ?? () from /usr/lib64/liburing.so.2
 #1  0x00007ffff7dfbca2 in __io_uring_get_cqe () from /usr/lib64/liburing.so.2
 #2  0x000055555556dd72 in io_uring_wait_cqe_nr (ring=0x555555807c30, cqe_ptr=0x7fffffffd9f0, wait_nr=1)
    at /usr/include/liburing.h:1175
 #3  0x000055555556df08 in io_uring_wait_cqe (ring=0x555555807c30, cqe_ptr=0x7fffffffd9f0)
    at /usr/include/liburing.h:1248
 #4  0x000055555557ff4f in boost::asio::detail::io_uring_service::run (this=0x555555807bf0, usec=-1, ops=...)
    at ../subprojects/boost_1_83_0/boost/asio/detail/impl/io_uring_service.ipp:437
 #5  0x000055555557e7a4 in boost::asio::detail::scheduler::do_run_one (this=0x555555806020, lock=...,
    this_thread=..., ec=...) at ../subprojects/boost_1_83_0/boost/asio/detail/impl/scheduler.ipp:477
 #6  0x000055555557e27a in boost::asio::detail::scheduler::run (this=0x555555806020, ec=...)
    at ../subprojects/boost_1_83_0/boost/asio/detail/impl/scheduler.ipp:210
 #7  0x0000555555581725 in boost::asio::io_context::run (this=0x7fffffffdc90)
    at ../subprojects/boost_1_83_0/boost/asio/impl/io_context.ipp:64
 #8  0x0000555555573af0 in main () at ../src/HwmonTempMain.cpp:643
```

Ran QEMU for Bletchley and observed HwmonTempSensor still works:
```
root@bletchley:~# busctl introspect xyz.openbmc_project.HwmonTempSensor /xyz/openbmc_project/sensors/temperature/SLED1_THERM_LOCAL xyz.openbmc_project.Sensor.Value
NAME                             TYPE      SIGNATURE RESULT/VALUE                             FLAGS
.MaxValue                        property  d         127                                      emits-change
.MinValue                        property  d         -128                                     emits-change
.Unit                            property  s         "xyz.openbmc_project.Sensor.Value.Uni... emits-change
.Value                           property  d         0                                        emits-change writable
```

Checking strace yields lots of io_uring related calls:
```
root@bletchley:~# strace -p 960
strace: Process 960 attached
io_uring_enter(4, 0, 1, IORING_ENTER_GETEVENTS, NULL, 8) = 0
clock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=810659232}) = 0
clock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=813407042}) = 0
io_uring_enter(4, 2, 0, 0, NULL, 8)     = 2
clock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=816897328}) = 0
io_uring_enter(4, 0, 1, IORING_ENTER_GETEVENTS, NULL, 8) = 0
clock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=822788059}) = 0
clock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=824535222}) = 0
```

Signed-off-by: Patrick Williams <[email protected]>
Change-Id: I0eb1d732a9bc3bb25e625b9f8fe3eeeaf8ae3143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pstrinkle