Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using namespace in header files #26

Open
bradbishop opened this issue Aug 19, 2021 · 0 comments
Open

using namespace in header files #26

bradbishop opened this issue Aug 19, 2021 · 0 comments
Assignees

Comments

@bradbishop
Copy link
Member

git grep 'using namespace' **.hpp

"using namespace" at global scope a header violates the cpp core guidelines:

https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rs-using-directive

"using namespace" in namespace scope is not called out but it is equally frowned upon because unexpected side effects:

foo.hpp:

namespace foo
{
    using namespace std;
};

main.cpp:

#include foo.hpp
using namespace foo; // oops - I have now pulled in namespace std?!?
@bradbishop bradbishop self-assigned this Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant