You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pldmtool hardcodes the version as {0xff, 0xff, 0xff, 0xff} for every request , ideally that should be fed as input through the pldmtool commands from the user and that should be filled inside the request message.
And also per base spec :
A value of 0xFF in the "update" field indicates that the entire field is not present. 0xFF is not allowed as a value for the "major" or "minor" fields. Software or utilities that display the version number should not display any characters for this field.
minor and major fields should never has 0xFF, its a spec violation.
pldm/pldmtool/pldm_base_cmd.cpp
Line 267 in 6f2a248
pldmtool's GetPLDMCommands command sends a placeholder version field that is not compatible with the DMTF's DSP0240.
Note that this shouldn't be fixed without also fixing issue #27.
The text was updated successfully, but these errors were encountered: