Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pldmtool: GetPLDMCommands is not spec-compliant #32

Open
FHomps opened this issue Feb 11, 2022 · 1 comment
Open

pldmtool: GetPLDMCommands is not spec-compliant #32

FHomps opened this issue Feb 11, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@FHomps
Copy link

FHomps commented Feb 11, 2022

ver32_t version{0xFF, 0xFF, 0xFF, 0xFF};

pldmtool's GetPLDMCommands command sends a placeholder version field that is not compatible with the DMTF's DSP0240.

Note that this shouldn't be fixed without also fixing issue #27.

@manojkiraneda manojkiraneda self-assigned this Apr 25, 2024
@manojkiraneda manojkiraneda added the bug Something isn't working label Apr 25, 2024
@manojkiraneda
Copy link
Contributor

pldmtool hardcodes the version as {0xff, 0xff, 0xff, 0xff} for every request , ideally that should be fed as input through the pldmtool commands from the user and that should be filled inside the request message.

And also per base spec :

A value of 0xFF in the "update" field indicates that the entire field is not present. 0xFF is not allowed as a value for the "major" or "minor" fields. Software or utilities that display the version number should not display any characters for this field.

minor and major fields should never has 0xFF, its a spec violation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants