Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match doesn't process errors from sd_bus_add_match #38

Open
fr0st61te opened this issue Sep 5, 2019 · 0 comments
Open

match doesn't process errors from sd_bus_add_match #38

fr0st61te opened this issue Sep 5, 2019 · 0 comments

Comments

@fr0st61te
Copy link

The sd_bus_add_match() method may return a lot of possible errors - ENOBUFS, ECHILD, EINVAL, etc. In sdbusplus/bus/match.hpp, in match() call the return code of sd_bus_add_match() is not checked, due to which the targeted watchers/listeners may silently fail without reporting anything to the end user.

For instance, some machine having a lot of sensors may have a lot of watchers for them.
However, after exceeding watcher/matchers limit it will not set up any new matches at all.

Another example: if there some typo in 'path', it will be silently eaten by sdbusplus interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant