Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about "can_read_multiple_v" in read.hpp #96

Open
ClaudiusJXK opened this issue Jul 19, 2024 · 2 comments
Open

about "can_read_multiple_v" in read.hpp #96

ClaudiusJXK opened this issue Jul 19, 2024 · 2 comments

Comments

@ClaudiusJXK
Copy link

I can't see the benefit of the grouping brought by "can_read_multiple_v" in read.hpp. Ultimately, everything is forwarded and called sequentially via "read_single_t". Why not simplify the process and directly call “read_single_t” for each argument of the read interface?

@williamspatrick
Copy link
Member

Good question. I'm not sure what happened here. At one point we use to call sd_bus_message_read with multiple values and it seems like that got lost at some point in some refactoring. You're right that right now it seems like we do tons of template processing for no reason. This is probably an opportunity for performance improvement to get us back to doing multiple reads in one shot.

@ClaudiusJXK
Copy link
Author

Thank you for your response. Looking forward to a more simplified code implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants