Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI has incorrect entries #8

Open
neomantra opened this issue Feb 27, 2024 · 4 comments
Open

OpenAPI has incorrect entries #8

neomantra opened this issue Feb 27, 2024 · 4 comments

Comments

@neomantra
Copy link

neomantra commented Feb 27, 2024

In the course of making and using go-openchargemap, some POI queries were failing due to inconsistencies between the OpenChargeMap OpenAPI spec and the the OpenChargeMap implementation:

You can find my modified OCM OpenAPI YAML here... In addition to the fixes here, it also adds:

  • one x-go-name: ChargePoint line due to Golang generation issues
  • changes the boundingbox query param from array to string as I was having issues; I think that might be me though.

I have tremendous gratitude for this project! Thank you! ❤️

neomantra added a commit to neomantra/go-openchargemap that referenced this issue Feb 27, 2024
@neomantra
Copy link
Author

Found another one:

neomantra added a commit to neomantra/go-openchargemap that referenced this issue Feb 29, 2024
@webprofusion-chrisc
Copy link
Member

Thanks! It would be great if you could submit a PR with the changes you think should be made. I normally manually edit the OpenAPI YAML using Stoplight studio, then when we push the update to github it automatically updates the docs page.

@neomantra
Copy link
Author

I will be happy to — I wasn’t sure if this file was actually the correct one to modify, so thanks for the clarification.

@webprofusion-chrisc
Copy link
Member

Thanks, yes that's the one.

neomantra added a commit to neomantra/ocm-docs that referenced this issue Mar 1, 2024
  * `latitude` in POI is `number`, not `integer`
  * `UserComments` IDs are `integer`, not `string`
  * `MediaItem` IDs are `integer`, not `string`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants